⚗️[Logs] POC dependency injection #2520
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2520 +/- ##
==========================================
- Coverage 93.22% 93.09% -0.13%
==========================================
Files 222 228 +6
Lines 6654 6736 +82
Branches 1460 1465 +5
==========================================
+ Hits 6203 6271 +68
- Misses 451 465 +14 ☔ View full report in Codecov by Sentry. |
BenoitZugmeyer
force-pushed
the
bcaudan/di
branch
from
7d502d0
to
820225a
Compare
Comment on lines
+26
to
33
| if (canUseEventBridge()) { | ||
| injector.override(startLogsSessionManager, startLogsSessionManagerStub) | ||
| injector.override(startLogsBatch, startLogsBridge) | ||
| } | ||
| const pageExitObservable = createPageExitObservable(configuration) | ||
|
|
||
| const session = | ||
| configuration.sessionStoreStrategyType && !canUseEventBridge() && !willSyntheticsInjectRum() | ||
| ? startLogsSessionManager(configuration) | ||
| : startLogsSessionManagerStub(configuration) | ||
|
|
||
| const { telemetry, stop: stopLogsTelemetry } = startLogsTelemetry( | ||
| configuration, | ||
| reportError, | ||
| pageExitObservable, | ||
| session.expireObservable | ||
| ) | ||
| cleanupTasks.push(() => stopLogsTelemetry()) | ||
| telemetry.setContextProvider(() => ({ | ||
| application: { | ||
| id: getRUMInternalContext()?.application_id, | ||
| }, | ||
| session: { | ||
| id: session.findTrackedSession()?.id, | ||
| }, | ||
| view: { | ||
| id: (getRUMInternalContext()?.view as Context)?.id, | ||
| }, | ||
| action: { | ||
| id: (getRUMInternalContext()?.user_action as Context)?.id, | ||
| }, | ||
| })) | ||
|
|
||
| startNetworkErrorCollection(configuration, lifeCycle) | ||
| startRuntimeErrorCollection(configuration, lifeCycle) | ||
| startConsoleCollection(configuration, lifeCycle) | ||
| startReportCollection(configuration, lifeCycle) | ||
| const { handleLog } = startLoggerCollection(lifeCycle) | ||
|
|
||
| startLogsAssembly(session, configuration, lifeCycle, buildCommonContext, reportError) | ||
|
|
||
| if (!canUseEventBridge()) { | ||
| const { stop: stopLogsBatch } = startLogsBatch( | ||
| configuration, | ||
| lifeCycle, | ||
| reportError, | ||
| pageExitObservable, | ||
| session.expireObservable | ||
| ) | ||
| cleanupTasks.push(() => stopLogsBatch()) | ||
| } else { | ||
| startLogsBridge(lifeCycle) | ||
| if (!configuration.sessionStoreStrategyType || willSyntheticsInjectRum()) { | ||
| injector.override(startLogsSessionManager, startLogsSessionManagerStub) | ||
| } |
There was a problem hiding this comment.
Note: those "override" in the wild could probably be moved in components, ex:
const startLogsTransport: Component<...> = (injector) => {
if (canUseEventBridge()) {
return injector.run(startLogsBridge)
} else {
return injector.run(startLogsBatch)
}
}| const injector: Injector = { | ||
| run(component) { | ||
| if (instances.has(component)) { | ||
| throw new Error(`Component ${component.name} already started`) |
There was a problem hiding this comment.
Note: This assertion and the following ones (in get and override) are not strictly needed, but helps to debug weird injection cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Play with a dependency injection approach to see how it could look like
Changes
Testing
I have gone over the contributing documentation.